Cyclic times #298
Merged
Cyclic times #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sub-daily time steps are not allowed
The external time dimension name should start with `time`, mainly used for different cyclic times.
Replaced monthly inflow climatology with daily (366) for testing different cyclic times.
dalmijn
reviewed
Sep 28, 2023
dalmijn
approved these changes
Sep 28, 2023
|
Thanks for the review @dalmijn! I have asked @JoostBuitink for a 2nd review. |
JoostBuitink
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Looks good to me, very nice addition! I have added some more information to the logging message when cyclic times are used (the number of timesteps per variable).
Furthermore, I also took the opportunity to include a small fix in the logging messages that display which (lake) csvs are being read that had been bothering me for some time ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #277
Explanation
Support different cyclic time inputs, for example monthly and daily. The time dimension name of the cyclic parameter in the input netCDF file should start with "time" (to allow for different time vectors).
Checklist
master