-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wflow_sbm figure leakage term and ksathorfrac
documentation
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add leakage term.
verseve
changed the title
Add leakage term to wflow_sbm figure
Wflow_sbm figure leakage term and Sep 28, 2023
ksathorfrac
documentation
including some minor doc improvements
Closed
@JoostBuitink : what did you use for the format changes, is that |
@verseve Oops, that was VSCode formatting the code for me (I assumed it was following JuliaFormatter, but that was not the case). The formatting changes should now be reverted, as I ran JuliaFormatter on this file. |
dalmijn
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #297, #279
Explanation
Added leakage term (and some minor improvements) to the wflow_sbm figure of the documentation.
Document external input parameter
ksathorfrac
.Checklist
master