Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wflow_sbm figure leakage term and ksathorfrac documentation #303

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

verseve
Copy link
Contributor

@verseve verseve commented Sep 27, 2023

Issue addressed

Fixes #297, #279

Explanation

Added leakage term (and some minor improvements) to the wflow_sbm figure of the documentation.
Document external input parameter ksathorfrac.

Checklist

  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

@verseve verseve added the documentation Improvements or additions to documentation label Sep 27, 2023
@verseve verseve requested a review from dalmijn September 27, 2023 13:35
@verseve verseve self-assigned this Sep 27, 2023
@verseve verseve removed the request for review from dalmijn September 28, 2023 06:03
@verseve verseve marked this pull request as draft September 28, 2023 06:03
@verseve verseve changed the title Add leakage term to wflow_sbm figure Wflow_sbm figure leakage term and ksathorfrac documentation Sep 28, 2023
including some minor doc improvements
@verseve verseve linked an issue Sep 29, 2023 that may be closed by this pull request
@verseve verseve marked this pull request as ready for review September 29, 2023 08:11
@verseve verseve requested a review from dalmijn September 29, 2023 08:11
@verseve
Copy link
Contributor Author

verseve commented Oct 13, 2023

@JoostBuitink : what did you use for the format changes, is that JuliaFormatter (with default settings)? That would be the preferred formatting style.

@JoostBuitink
Copy link
Contributor

@verseve Oops, that was VSCode formatting the code for me (I assumed it was following JuliaFormatter, but that was not the case). The formatting changes should now be reverted, as I ran JuliaFormatter on this file.

@verseve verseve merged commit dea75e1 into master Nov 9, 2023
12 checks passed
@verseve verseve deleted the wflow_sbm_figure branch November 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add leakage term to wflow_sbm figure document ksathorfrac
4 participants