Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for NCDatasets to 0.13, (keep existing compat) #305

Merged
merged 5 commits into from
Nov 16, 2023
Merged

CompatHelper: bump compat for NCDatasets to 0.13, (keep existing compat) #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c592705
CompatHelper: bump compat for NCDatasets to 0.13, (keep existing compat)
Oct 5, 2023
8a943c0
fix compat with ncdatasets
JoostBuitink Nov 9, 2023
4f2c11b
Merge branch 'master' into compathelper/new_version/2023-10-05-11-53-…
JoostBuitink Nov 16, 2023
5569f2b
Update changelog.md
JoostBuitink Nov 16, 2023
e545571
Merge branch 'master' into compathelper/new_version/2023-10-05-11-53-…
JoostBuitink Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Graphs = "1.4"
IfElse = "0.1"
LoggingExtras = "0.4.6,0.5,1"
LoopVectorization = "0.12"
NCDatasets = "0.12.11"
NCDatasets = "0.13"
Parameters = "0.12"
Polyester = "0.7"
Polynomials = "3,4"
Expand Down
1 change: 1 addition & 0 deletions docs/src/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Documentation: add leakage term to the wflow\_sbm figure, document external input
parameter `ksathorfrac` and fix description of adding external `inflow` to the kinematic
wave.
- Bump compat for NCDatasets to 0.13.

### Changed
- For cyclic parameters different cyclic time inputs are supported (only one common cyclic
Expand Down
2 changes: 1 addition & 1 deletion test/horizontal_process.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const ldd_mv = 255
# read the staticmaps into memory
nc = NCDataset(staticmaps_rhine_path)
# helper function to get the axis order and directionality right
read_right(nc, var) = reverse(permutedims(nc[var][:]); dims = 2)
read_right(nc, var) = reverse(permutedims(Array(nc[var])); dims = 2)
ldd_2d = read_right(nc, "ldd")

inds, _ = Wflow.active_indices(ldd_2d, ldd_mv)
Expand Down
Loading