Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for NCDatasets to 0.14, (keep existing compat) #321

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the NCDatasets package from 0.13 to 0.13, 0.14.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2023-12-19-11-52-02-928-02959025079 branch from b89a6f9 to 6080f38 Compare December 19, 2023 11:52
method haskey(::CommonDataModel.MFDataset{NCDataset{Nothing}, 1, String}, ::String) unknown with NCDatasets 0.14.
@verseve verseve requested a review from visr January 9, 2024 15:36
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@visr visr merged commit c87de62 into master Jan 9, 2024
12 checks passed
@visr visr deleted the compathelper/new_version/2023-12-19-11-52-02-928-02959025079 branch January 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants