Total Water Storage #327
Merged
Total Water Storage #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostBuitink
requested changes
Jan 17, 2024
|
Indeed nice work @dalmijn ! I agree with Joost his comments, and I did add a couple of small comments (mainly a suggestion to opt for one function at the |
verseve
suggested changes
Jan 17, 2024
verseve
reviewed
Jan 18, 2024
verseve
suggested changes
Jan 24, 2024
verseve
approved these changes
Jan 29, 2024
JoostBuitink
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #281
Explanation
Simple added it to the SBM struct, added the h_av flow.jl for land and river (with riverfrac)
It's done in millimeters [mm]
Checklist
masterAdditional Notes (optional)
Add any additional notes or information that may be helpful.