Quality of life improvements #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Looks good! The explicit imports (can be done using https://github.com/ericphanson/ExplicitImports.jl) help making it clear where functions come from. And I also prefer the NamedTuple unpacking over the unpack macro. The NamedTuple unpacking didn't exist when this code was first written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What better way to get to know a new repository than to hack around in it :-) In this branch I did 2 things:
@unpackmacro: this macro (and theUnPackpackage) is no longer needed because of the named tuple notation for obtaining fields from objects. An advantage of this notation is that VSCode indicates whether the field name is actually used in the given scope, which allowed me to clean up the code a bitWflow.jlwhat is actually used from the dependenciesI accidentally also upgraded the Julia version to 1.11, if you don't want this let me know.