Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker building #501

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Fix docker building #501

merged 6 commits into from
Nov 14, 2024

Conversation

JoostBuitink
Copy link
Contributor

@JoostBuitink JoostBuitink commented Nov 13, 2024

Issue addressed

No issue, docker was failing to build on teamcity, due to missing test data (as a result from moving to pixi tasks).

Explanation

Run script to download testdata in the docker file (and remove when done, as these files are not needed inside the docker).

Checklist

  • Updated tests or added new tests
  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works. Note that in the future, you might be able to create a slightly smaller image by combining all Julia steps in one, just like the apt-get step. Every RUN creates it's own layer in the Docker image.

@JoostBuitink JoostBuitink merged commit c6aef34 into master Nov 14, 2024
9 checks passed
@JoostBuitink JoostBuitink deleted the fix_docker branch November 14, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants