Use Configurations.jl for configuration
#519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example config print: |
8 tasks
Comment on lines
+261
to
+273
| @option struct Input <: TableOption | ||
| path_forcing::String = "." | ||
| path_static::String = "." | ||
| gauges::String = "wflow_gauges" | ||
| gauges_grdc::String = "wflow_gauges_grdc" | ||
| ldd::String = "wflow_ldd" | ||
| river_location::String = "wflow_river" | ||
| subcatchment::String = "wflow_subcatch" | ||
| forcing::Vector{String} = String[] | ||
| cyclic::Vector{String} = String[] | ||
| vertical::InputVertical = InputVertical() | ||
| lateral::InputLateral = InputLateral() | ||
| end |
There was a problem hiding this comment.
Perhaps good to mention here, is that in the input section, we allow users to define their own maps, which can be used to write output (think of different subbasin maps, different types of gauges). So there are a couple of required option (e.g. path_forcing, path_static), it is also a very flexible section).
Same holds for the output sections: this can be any parameter (e.g. lateral.river.q and lateral.river.h, but also vertical.satwaterdepth, etc), so I don't think we would want to explicitly mention all the available options here, because that will become quite messy.
There was a problem hiding this comment.
I see. I'm not sure such flexibility is possible within this structure, better ask @evetion.
There was a problem hiding this comment.
Maybe worth to implement our own structure/methods for this?
There was a problem hiding this comment.
I guess at least some of the config structure is static and could use Configurations, and for the flexible part you use a dict?
There was a problem hiding this comment.
Yes, good point, we could indeed use Configurations for the static part.
There was a problem hiding this comment.
Also, what a huge config you guys have. 😁
There was a problem hiding this comment.
You pay a certain price for flexibility 😉...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #243.
Additional Notes (optional)
Probably needs to be coordinated with #518.