Overwriting files that were lazily loaded results in permission error…

[roeldegoede]

…s. Loading the data first solves that problem.

Issue addressed

When reading in a sfincs model with netcdf files (as grid (future)), subgrid or as forcing), these datasets are lazily loaded. In theory, that increases performance, because data is only loaded when necesssary. However, due to lazy references to the data in the original files, the files cannot be overwritten when you write the model.

Of course, you could choose to only write the files that you changed, but often the SfincsModel.write() is used.

Explanation

Everywhere where we would like to write a netcdf, we first check if the file already exists. If that is the case, we have to load the data into memory first, such that we can overwrite the file after (after loading, the lazy references are gone).

Checklist

• [x ] Updated tests or added new tests
• [x ] Branch is up to date with main
• Updated documentation if needed
• Updated changelog.rst if needed

Additional Notes (optional)

Question is whether we even want to load and overwrite datasets that are still lazy, because in most cases that will mean that they are unchanged and loading/writing would result in unnecessary computations?

[roeldegoede]

Somehow, the tests that I implemented to guarantee this would work (which it perfectly did locally) fail online with he same permission errors as before. However, since everything works on my side, it's very hard to debug.. @DirkEilander or @LuukBlom any suggestions are welcome.