Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement regridding for more Metaswap packages #1001

Closed
luitjansl opened this issue Apr 30, 2024 · 2 comments · Fixed by #1151
Closed

implement regridding for more Metaswap packages #1001

luitjansl opened this issue Apr 30, 2024 · 2 comments · Fixed by #1151
Assignees
@luitjansl
Milestone
v1.0: Backwards C...

Comments

@luitjansl
Copy link
Contributor

Some metaswap packages cannot be regridded yet, these are:

  • CouplerMapping
  • GridData,
  • Sprinkling
  • MeteoMapping
  • IdfMapping

Regridding needs to be implemented for these packages.
(the Model itself would also benefit from a regrid_like method. )
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Apr 30, 2024
@luitjansl luitjansl mentioned this issue Apr 30, 2024
Merged
5 tasks
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Jul 3, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 🏗 In Progress in iMOD Suite Aug 8, 2024
@luitjansl
Copy link
Contributor Author

luitjansl commented Aug 8, 2024 •
edited
Loading

status:

@luitjansl luitjansl mentioned this issue Aug 14, 2024
Merged
5 tasks
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Aug 15, 2024
luitjansl added a commit that referenced this issue Aug 16, 2024
@luitjansl
Issue #1001 more msw regrid packages simplified (#1151)
8e103f4 
Fixes #1001 

# Description
adds regridding for metaswap packages meteo and grid_data
Adds a utility function for computing cell area and grid area for
equidistant and non-equidistant grids.

# Checklist


- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@luitjansl
Copy link
Contributor Author

merged to metaswap regridding feature branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0: Backwards Compatibility iMOD5
Development

Successfully merging a pull request may close this issue.

Issue #1001 more msw regrid packages simplified Deltares/imod-python
2 participants
@JoerivanEngelen @luitjansl