Issue #1001 more msw regrid packages simplified #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luitjansl
changed the base branch from
master
to
metaswap_regridding_feature_branch
…re_msw_regrid_packages_simplified # Conflicts: # imod/tests/test_msw/test_annual_crop_factors.py
…01_more_msw_regrid_packages_simplified
…re_msw_regrid_packages_simplified
…re_msw_regrid_packages_simplified # Conflicts: # imod/msw/grid_data.py # imod/msw/infiltration.py # imod/msw/ponding.py # imod/msw/scaling_factors.py
JoerivanEngelen
approved these changes
Aug 16, 2024
imod/util/spatial.py
Outdated
| @@ -736,3 +736,48 @@ def _polygonize(da: xr.DataArray) -> "gpd.GeoDataFrame": | |||
| gdf = gpd.GeoDataFrame({"value": colvalues, "geometry": geometries}) | |||
| gdf.crs = da.attrs.get("crs") | |||
| return gdf | |||
|
|
|||
|
|
|||
| def get_grid_area(array: xr.DataArray) -> float: | |||
There was a problem hiding this comment.
Maybe: get_total_grid_area is more explicit? "grid_area" could still mean "a grid of cell areas" if you don't know that also a function named get_cell_area exists
| @@ -6,6 +6,7 @@ | |||
| import xugrid as xu | |||
|
|
|||
| import imod | |||
| from imod.util.spatial import get_cell_area | |||
There was a problem hiding this comment.
I don't see tests for get_grid_area?
|
luitjansl
merged commit 8e103f4
into
metaswap_regridding_feature_branch
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1001
Description
adds regridding for metaswap packages meteo and grid_data
Adds a utility function for computing cell area and grid area for equidistant and non-equidistant grids.
Checklist
Issue #nr, e.g.Issue #737