Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Modflow6Simulation.dump doesn't work when HFB package is added #1343

Closed
JoerivanEngelen opened this issue Dec 16, 2024 · 0 comments · Fixed by #1346
Closed

[Bug] - Modflow6Simulation.dump doesn't work when HFB package is added #1343

JoerivanEngelen opened this issue Dec 16, 2024 · 0 comments · Fixed by #1346
Assignees
Labels
bug Something isn't working

Comments

@JoerivanEngelen
Copy link
Contributor

Bug description
There is a misalignment between Modflow6Simulation.dump and Package.to_netcdf
The dump method should call the Package.to_netcdf method, however it now features its own custom logic to deal with UGRID data and MDAL prepared data, which should be moved Package.to_netcdf.

This is especially a problem for HorizontalFlowBarrierBase.to_netcdf, as this features specific logic which is a hard requirement to even succesfully save to netcdf.

Steps to reproduce
See #1322

Desktop (please complete the following information):

  • OS: Windows 11
  • iMOD Python Version: 0.18.1 dev
@JoerivanEngelen JoerivanEngelen added the bug Something isn't working label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Dec 16, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this Dec 16, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🧐 In Review in iMOD Suite Dec 16, 2024
@JoerivanEngelen JoerivanEngelen added this to the v1.0 release milestone Dec 16, 2024
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant