Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1343 hfb dump #1346

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Issue #1343 hfb dump #1346

merged 10 commits into from
Dec 17, 2024

Conversation

JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Dec 16, 2024

Fixes #1343

Description

  • Fix crash when calling GroundwaterFlowModel.dump when a HFB was assigned to the model
  • Really encode HFB as string this time when calling to_netcdf...
  • Move MDAL/GDAL logic to Package.to_netcdf, which is a more logical place for it then in Model.dump. This has the advantage that this stuff is automatically not done when we override the method for the HFB package, as the MDAL/CRS stuff is irrelevant for HFBs.
  • Drop node_dim from UGRID dataset if present, it still remains available in the grid topology.
  • Ensure non-scalar data not loaded into memory when calling from_file.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@JoerivanEngelen JoerivanEngelen merged commit fdc827b into master Dec 17, 2024
7 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1343_hfb_dump branch December 17, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Modflow6Simulation.dump doesn't work when HFB package is added
2 participants