Issue #1161 metaswap regrid model #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoerivanEngelen
approved these changes
Aug 23, 2024
imod/msw/model.py
Outdated
Comment on lines
261
to
262
| mod2svat = self.pop("mod2svat", None) | ||
| grid = self.pop("grid", None) |
There was a problem hiding this comment.
These keys are not hardcoded, but decided by the user. I think you have to find packages based on their type and pop them I fear...
imod/msw/sprinkling.py
Outdated
Comment on lines
98
to
99
| def is_regridding_supported(self) -> bool: | ||
| return False |
There was a problem hiding this comment.
Please add a comment that this can be changed when this is resolved #728
|
luitjansl
merged commit 4aef0c6
into
metaswap_regridding_feature_branch
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
Description
Implemented a regrid_like method for metaswap models
Checklist
Issue #nr, e.g.Issue #737