Add experimental MetaSWAP regridding functionality. #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #365 # Description Adds regrid functionality to a number of metaswap packages Adds unittests for regridding these packages # Checklist - [X] Links to correct issue - [ ] Update changelog, if changes affect users - [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [X] Unit tests were added - [ ] **If feature added**: Added/extended example
# Conflicts: # imod/msw/initial_conditions.py # imod/tests/test_msw/test_landuse_options.py
Fixes #1152 # Description Metaswap does not have the RegridderMethodType dataclass yet, so its regridding method data were still a dictionary. This PR implements RegridderMethodType dataclasses for metaswap, and moves some base classes used for regridding to imod.utils (they were in imod/mf6before) # Checklist - [X] Links to correct issue - [ ] Update changelog, if changes affect users - [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example
Fixes #1001 # Description adds regridding for metaswap packages meteo and grid_data Adds a utility function for computing cell area and grid area for equidistant and non-equidistant grids. # Checklist - [x] Links to correct issue - [ ] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [x] Unit tests were added - [ ] **If feature added**: Added/extended example
Fixes #1161 # Description Implemented a regrid_like method for metaswap models # Checklist <!--- Before requesting review, please go through this checklist: --> - [x] Links to correct issue - [ ] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [x] Unit tests were added - [ ] **If feature added**: Added/extended example
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds experimental MetaSWAP regridding. It doesn't work yet for the sprinkling package, because this requires #728.
Mostly developed by @luitjansl , so all credits go to him for this functionality.
Checklist
Issue #nr, e.g.Issue #737