Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #344 part1 imod refactor primod update #346

Conversation

JoerivanEngelen
Copy link
Contributor

Closes #344, this is the first task to update primod for the iMOD Python refactor.

Plans are layed out in #342. In this first task, I changed the use of the deprecated WellDisStructured object, to the Mf6Wel object, which is a direct translation of MODFLOW 6's cellids to a file. As this iMOD Python refactor is still work in progress, I temporarily introduce a install-imod task, which pip installs imod from a git branch, instead of a release on conda-forge. After I have accomplished part 2 of the refactors, I'll make an iMOD Python release, and this can be reverted back.

It does the following things:

@JoerivanEngelen JoerivanEngelen merged commit 139acd4 into issue_#342_imod_refactor_primod_update Oct 28, 2024
4 of 8 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#344_part1_imod_refactor_primod_update branch October 28, 2024 16:33
@JoerivanEngelen JoerivanEngelen restored the issue_#344_part1_imod_refactor_primod_update branch October 28, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant