add also to to_geodataframe

Deltares · Aug 20, 2024 · 67daff5 · 67daff5
1 parent b66b6b1
commit 67daff5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/xugrid/core/dataarray_accessor.py b/xugrid/core/dataarray_accessor.py
@@ -422,7 +422,7 @@ def to_geodataframe(
         else:
             ds = self.obj.to_dataset()
 
-        variables = [var for var in ds.data_vars if dim in ds[var].dims]
+        variables = [var for var in ds.data_vars if dim in ds.variables[var].dims]
         # TODO deal with time-dependent data, etc.
         # Basically requires checking which variables are static, which aren't.
         # For non-static, requires repeating all geometries.

diff --git a/xugrid/core/dataset_accessor.py b/xugrid/core/dataset_accessor.py
@@ -546,7 +546,7 @@ def to_geodataframe(self, dim_order=None) -> "geopandas.GeoDataFrame":  # type:
             else:
                 raise ValueError("invalid topology dimension on grid")
 
-            variables = [var for var in ds.data_vars if dim in ds[var].dims]
+            variables = [var for var in ds.data_vars if dim in ds.variables[var].dims]
             if variables:
                 data = ds[variables].to_dataframe(dim_order=dim_order)
             else: