Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix affected projects tab not being updated when switching between vulnerability aliases #509

Conversation

sephiroth-j
Copy link
Contributor

@sephiroth-j sephiroth-j commented May 30, 2023

Description

The affected projects tab (and table) is not updated correctly when switching between aliases.

Addressed Issue

fixes #481

Additional Details

I'm leaving this as a draft for now because there is also a backend issue that should be fixed first (see #481 (comment)).

Checklist

@sephiroth-j
Copy link
Contributor Author

Hello @valentijnscholten, would you please check if this actually fixes the problem you described in #481?

@valentijnscholten
Copy link
Contributor

The response in affected projects from the backend will be different for an alias, that's the reason the tab must be refreshed.
If the responses were the same, a refresh of the tab would not be needed. I will test if the fix works.

@valentijnscholten
Copy link
Contributor

@sephiroth-j Sorry for the late reply, needed some time to get DT going again locally and be able to build the PR.
But it doesn't seem to work. I think I have tried this solution as well, but the props aren't changing when the user switches to the alias.

@valentijnscholten
Copy link
Contributor

valentijnscholten commented Jan 1, 2025

Oh sorry, there were some errors running npm run serve. Just reapplied your changes onto master and it works!
Thanks. Could you rebase? If you rebase it on the 4.12.x branch it might make it into the next bugfix release.

@sephiroth-j sephiroth-j force-pushed the issue-481-affected-projects-tab-not-updated branch from c652559 to 7fc4669 Compare January 4, 2025 17:30
@sephiroth-j sephiroth-j changed the base branch from master to 4.12.x January 4, 2025 17:30
@sephiroth-j sephiroth-j marked this pull request as ready for review January 4, 2025 17:31
@sephiroth-j
Copy link
Contributor Author

Hi @valentijnscholten, I have rebased the bugfix branch to 4.12.x and updated the target branch of the PR accordingly.

Copy link
Contributor

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it still works :-D

@valentijnscholten
Copy link
Contributor

@sephiroth-j Can you sign your commits?

@sephiroth-j
Copy link
Contributor Author

@valentijnscholten my commit is signed. I think you just need to re-run the DCO check.

@valentijnscholten
Copy link
Contributor

@sephiroth-j I can't. I think it'll run if close->reopen the PR.

@nscuro
Copy link
Member

nscuro commented Jan 11, 2025

I have manually passed the DCO check since @sephiroth-j's commit is indeed signed off.

@nscuro nscuro added this to the 4.12.3 milestone Jan 11, 2025
@nscuro nscuro added the defect Something isn't working label Jan 11, 2025
@nscuro nscuro changed the title Issue 481: Affected projects tab not updated when switching between aliases Fix affected projects tab not being updated when switching between vulnerability aliases Jan 11, 2025
@nscuro nscuro merged commit d6aec68 into DependencyTrack:4.12.x Jan 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affected projects tab not updated when switching between aliases
3 participants