Use Java8 to build artifacts #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
commented
Mar 10, 2023
| @@ -88,29 +88,13 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| agp_version: | |||
| - '3.5.1' | |||
There was a problem hiding this comment.
Dropped these AGP versions. They basically require Java7 binary.
jmatsu
commented
Mar 10, 2023
| @@ -2,14 +2,13 @@ apply plugin: 'com.android.application' | |||
| apply plugin: 'deploygate' | |||
|
|
|||
| android { | |||
There was a problem hiding this comment.
Updated the example project and remove unnecessary dependencies.
jmatsu
commented
Mar 10, 2023
| @@ -1,78 +1,129 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Revised the wrapper file.
jmatsu
commented
Mar 10, 2023
| @@ -45,30 +43,14 @@ class PackageAppTaskCompat { | |||
|
|
|||
| @PackageScope | |||
| static boolean hasSigningConfig(packageAppTask) { | |||
| if (!AndroidGradlePlugin.isSigningConfigProviderSupported()) { | |||
There was a problem hiding this comment.
All compat methods return true so inlined them. The last branches are chosen by design.
jmatsu
commented
Mar 10, 2023
| @@ -14,4 +14,15 @@ class DeployGateTaskFactorySpec extends Specification { | |||
| "dep2" | "uploadDeployGateDep2" | |||
| "dep3Dep4" | "uploadDeployGateDep3Dep4" | |||
| } | |||
|
|
|||
| def "uploadAabTaskName should return #taskName"() { | |||
satsukies
approved these changes
Mar 13, 2023
Co-authored-by: satsukies <[email protected]>
Co-authored-by: satsukies <[email protected]>
|
Thank you for your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #152
Close #165
This change drops AGP versions lower than 4.2.0 because of the compatibility. And also, Gradle is upgraded.