Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env stub class for testing is broken #241

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Env stub class for testing is broken #241

merged 2 commits into from
Oct 16, 2024

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Oct 16, 2024

Environment variables were purged due to mock implementation so that HttpClient cannot look up required values.

@jmatsu jmatsu changed the title DONT MERGE: Investigate why the input parameters of HttpClient has gone Env stub class for testing is broken Oct 16, 2024
@jmatsu jmatsu marked this pull request as ready for review October 16, 2024 08:37
@jmatsu jmatsu requested a review from satsukies October 16, 2024 08:37
Copy link
Member

@satsukies satsukies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the mechanism of test job failure.
Thanks a lot.
LGTM

@jmatsu jmatsu merged commit 4271e81 into master Oct 16, 2024
19 checks passed
@jmatsu jmatsu deleted the jmatsu-patch-1 branch October 16, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants