-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cases: broke down into separate files and fixed some headers that… #63
Conversation
… had not been updated. We do need to check the links from the nav because they want to connect to an anchor, not a file, which is how they are set up now.
❌ Deploy Preview for ds-user-guide failed. Why did it fail? →
|
This reverts commit 02d8621.
* feat: DES-3045 allow non-flat nav (TACC-Docs 0.10) * test: DES-3045 use non-flat nav from #63 * Revert "test: DES-3045 use non-flat nav from #63" This reverts commit 02d8621. --------- Co-authored-by: Silvia Mazzoni <[email protected]>
There are navigation bugs when using flat navigation. Reported in DES-3045. Expect solution via TACC-Docs update. |
Tip If testing via Docker, there are no navigation bugs introduced by this change. Caution If testing via Python, several navigation bugs are introduced by this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wes, do you have an update on this? |
No update. Same status as it was in #63 (review). I've been taken by DesignSafe website work and another project. Still an excellent PR. I don't mind it staying open, let's me know what is still waiting on me. If you are okay with the nav bugs for Python-based testing, please tell and reopen so I can merge. Otherwise, this would wait until have time to solve #66. |
The nav bugs are are only on my testing end, correct? |
Yes x4. Merged. |
Overview
Broke down Use Cases into separate files and fixed some headers that had not been updated.
Testing
We do need to check the links from the nav because they want to connect to an anchor, not a file, which is how they are set up now.
UI
since TACC-Docs v0.10
since.tacc-docs.v0100.-.click.triangle.mov
since.tacc-docs.v0100.-.click.text.mov
using TACC-Docs v0.8
sample.document.navbar.mov
detailed.nav.is.automatically.open.mov
edited by @wesleyboar (organized and added visuals)