Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new account page, new nav section, smaller homepage #67

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Jul 27, 2024

Overview

Update homepage. Move account access to new page. New top nav section.

Status

Important

Pending stakeholder review (internal, private).

Related

Changes

  • removed date last updated (can be found on GitHub)
  • moved account access to its own page
  • changed "Tools & Apps" to "Tools and Apps" (to match nav)
  • added new nav section "DesignSafe Essentials" (like TACC Docs)

Testing

  1. Open:
  2. See:
    • new nav section "DesignSafe Essentials"
    • new content "DesignSafe Essentials: …"
  3. Verify Documentation Outline is highlighted (as current).
  4. Click Account Access.

UI

After enhance: rework as Getting Started & Account Help

Getting Started

before after
index - old index - new

Account Help

before after
account - old account - new
(lost)

Before enhance: rework as Getting Started & Account Help

Homepage & Nav

before after
before homepage change after homepage change

Account Access

before after
before homepage change account access

@wesleyboar wesleyboar marked this pull request as ready for review July 27, 2024 00:38
@wesleyboar wesleyboar mentioned this pull request Jul 27, 2024
@wesleyboar wesleyboar changed the title feat: new account page, new nav section, smaller homepage` feat: new account page, new nav section, smaller homepage Jul 27, 2024
@wesleyboar wesleyboar requested a review from silviamazzoni July 27, 2024 00:40
@wesleyboar
Copy link
Collaborator Author

@silviamazzoni, Please take a look at this new index page and top section. It's changed since last time. At least during today, you can preview it on https://designsafeci-dev.tacc.utexas.edu/user-guide/.

@silviamazzoni
Copy link
Collaborator

Wes, I am happy to meet. The main note is that the section titles, such as DesignSafe Essentials, Data Depot, Tools and Apps, etc should be aligned left so that we know they are not a link. a different format could work.
The difference between Data Depot and Overview is so small, and yet Overview has a link.
Why does Overview in Simulation Applications actually have sections that don't seem like an overview.... And why do DS Essentials and Tools and Apps not have an Overview?

@silviamazzoni
Copy link
Collaborator

also, clicking on a section in the Use Cases overview should open up the corresponding item in the nav...

@silviamazzoni
Copy link
Collaborator

Also, there is still too much empty space at the top, both in the nav and in the page.

@silviamazzoni
Copy link
Collaborator

also, when I clikc on an item in the nav, it scrolls the left nav up so that that item is that at the top... very disturbing and makes it hard to visualize the full section.

@wesleyboar
Copy link
Collaborator Author

wesleyboar commented Sep 16, 2024

Understood.

The difference between Data Depot and Overview is so small, and yet Overview has a link.

Known issue; in progress:

Other feedback seems external to the problem being solved (which is adding "Getting Started" and restoring lost content to get help for account).


I gather it for reference, and give answers.

Section titles, such as DesignSafe Essentials, Data Depot, Tools and Apps, etc should be aligned left […]

This is a reasonable opinion. Although, in one sense, they are aligned left because the text is aligned left; the arrow is outside the alignment. Independent of this content-focused PR, feel free to continue to remind me about this element. (I forget what designer's feedback was when last I mentioned it.)

Why does Overview in Simulation Applications actually have sections that don't seem like an overview....

Uncertain. I am unfamiliar with pre-existing content.

And why do DS Essentials and Tools and Apps not have an Overview?

Uncertain. I presume "Overview" pages are new additions and have not been viewed as a standard per section.

Update:

Also, there is still too much empty space at the top, both in the nav and in the page.

Design concern. Seems irrelevant to the problem this PR solves. Feel free to open a new issue.

[When I click] on an item in the nav, it scrolls the left nav up so that that item is that at the top... very disturbing and makes it hard to visualize the full section.

Aye, it does. Sometimes it can not scroll item to top, and instead scrolls nav up as far as it can, with relevant item appearing in the middle of the nav. I am continuously aware of this issue, and hope it is fixed on its own after https://github.com/TACC/TACC-Docs/issues/53.

@wesleyboar
Copy link
Collaborator Author

I updated my original response with answers to feedback I missed.

Also, there is still too much empty space at the top, both in the nav and in the page.

Design concern. Seems irrelevant to the problem this PR solves. Feel free to open a new issue.

[When I click] on an item in the nav, it scrolls the left nav up so that that item is that at the top... very disturbing and makes it hard to visualize the full section.

Aye, it does. Sometimes it can not scroll item to top, and instead scrolls nav up as far as it can, with relevant item appearing in the middle of the nav. I am continuously aware of this issue, and hope it is fixed on its own after https://github.com/TACC/TACC-Docs/issues/53.

@wesleyboar
Copy link
Collaborator Author

Merging based on informal approval.

I made these changes under @heddabedda's direction.

I got review from @silviamazzoni (colleague), @heddabedda's (new author), and one project stakeholder. Original content is basically as is, just moved around. I will request a second stakeholder to scan it after deploy.

@wesleyboar wesleyboar merged commit 09d0e2e into main Sep 17, 2024
@wesleyboar wesleyboar deleted the feat/split-index-page-in-two branch September 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage Update
2 participants