Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DES-2432: Update Software License #1107

Merged
merged 4 commits into from
Oct 25, 2023
Merged

DES-2432: Update Software License #1107

merged 4 commits into from
Oct 25, 2023

Conversation

SilversunKSauri
Copy link
Contributor

Overview:

Replaced the GNU license with the 3-Clause BSD License

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

In the publication pipeline, the Software License option has been replaced.
Code that references the GNU license has been left for displaying and managing publications that may already be using this license.
New icon file for the new license.

Testing Steps:

  1. Take a new project (as in not already published) and go through the pipeline to make sure the new license shows up.
  2. On a separate branch, not this branch, do a new publication with the old GNU license.
  3. Using this branch, do a new publication with the new 3-Clause license.
  4. While still on this branch, go to the publication view and make sure both publications show the appropriate license (gnu or 3-clause).
  5. Check the "Download Dataset" window for both publications and check that the appropriate license info is showing based on the publication's license.

UI Photos:

Showing old license:
Screenshot 2023-10-10 at 4 29 40 PM

Download Dataset for old license:
Screenshot 2023-10-10 at 4 29 54 PM

Showing new license:
Screenshot 2023-10-10 at 4 30 08 PM

Download Dataset for new license:
Screenshot 2023-10-10 at 4 30 18 PM

New license in the publication pipeline:
Screenshot 2023-10-10 at 4 31 46 PM

Notes:

Copy link
Contributor

@van-go van-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with new publication, shows new icon and details. Old publication shows old icon and details. LGTM.

@jarosenb jarosenb merged commit 9fe21e6 into main Oct 25, 2023
@jarosenb jarosenb deleted the des-2432 branch October 25, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants