-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/des 2558 updates to metadata #1134
Conversation
I think the new additions are good, but we should hold off on the places (like fire->wildfire) where one dropdown value changes into another. The reason is that it creates an issue with legacy metadata when it comes to search filtering in publications. For instance with fire->wildfire, changing the value in the search filters will cause us to exclude old "fire" publications unless we hard-code a workaround into the search. Then we're stuck maintaining that workaround forever. The more maintainable way to support these changes would be a name/label system like with facilities, so old projects would have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll create another ticket to merge fire/wildfire.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Updates to search_utils.py and project-form-options.json
Changes to manage-project.template.html to allow custom write-in
Testing Steps:
UI Photos:
Notes:
I create a project with an now removed Data Type option(Field Survey). In both published and projects, the old Data Type appears as text (not drop-down option). The user can leave the text as is, or delete the text, then the drop-down full of options appears for them to choose from. Changes appear in Published.
Another part of this ticket was to allow multiple Data Types. I moved this to DES-2570 which is a request to allow multiple facilities. These can be worked on together when we decide how to handle changes to data types (string to list).