Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/des 2306 Allow Metric Data only at DOI level #1157

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Jan 11, 2024

Overview:

DesignSafe Project and Publications should report reuse metrics but only at the DOI level. It looks like Field Research -Social Science Collection projects have them (Data Reuse "View Collection Metrics"). Since this is a level below Mission, this is wrong.
Simulation, Experimental, and Hybrid Simulation type projects appear to report properly.
FR Mission: Research Planning Collection, FR Mission: Engineering/Geoscience Collection, and FR Documents appear to report correctly.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Removed 'Data Reuse' from FR Amends (Document & Mission)
Removed 'Data Reuse' from FR Published Mission - Social Science Collections section

Testing Steps:

  1. In my Projects, find an FR. Go through the Amends pipeline and make sure 'Data Reuse' does not appear.
  2. Also in my Projects, confirm that 'Data Reuse' does not exist in any project types.
  3. in Published, find an FR project. Verify that 'Download/View/Citation' Details link appears and works for Documents and Missions. Also check that the metric data does not appear in any of the sub levels to Missions.
  4. While in Published, check the other project types and verify that the 'Download/View/Citation' Details link appears and works at the correct level. Check that metric data does not appear elsewhere.

UI Photos:

Screen Shot 2024-01-11 at 3 10 42 PM

Notes:

@van-go van-go changed the title Task/des 2306 allow metric data only at doi level Task/des 2306 Allow Metric Data only at DOI level Jan 11, 2024
@van-go van-go marked this pull request as ready for review January 11, 2024 21:38
@jarosenb jarosenb merged commit 43be928 into main Mar 6, 2024
3 checks passed
@jarosenb jarosenb deleted the task/des-2306-allow-metric-data-only-at-doi-level branch March 6, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants