Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/des 2107 publication download text update #1163

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Jan 24, 2024

Overview:

We don't allow downloads for datasets larger than 2GB. This PR changes the wording and leads the user to create a TUP account to download large files. Also removes the download button is the download is greater than 2GB, getting rid of an extra popup screen.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Used conditional statement to change text that appears in a download is greater than 2 GB.
Used conditional statement to determine if 'Download' button appears.

Testing Steps:

  1. Find a project with a dataset size greater than 2GB. Notice the text and lack of Download button.
  2. Find a proejct with a dataset less than or equal to 2GB. The text and Download button should appear as normal.

UI Photos:

Dataset > 2GB:
Screen Shot 2024-01-24 at 11 44 42 AM

Dataset <= 2GB:
Screen Shot 2024-01-24 at 11 45 05 AM

Notes:

Copy link
Contributor

@SilversunKSauri SilversunKSauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarosenb jarosenb merged commit 7410ee4 into main Jan 29, 2024
3 checks passed
@jarosenb jarosenb deleted the task/des-2107-publication-download-text-update branch January 29, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants