Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WI-221: Add retry decorator and retry system access steps during onboarding #1486

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

rstijerina
Copy link
Member

Overview:

Add retry decorator, and retry steps during System Access step known to be time-sensitive.

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Create a test user and delete their 'My Data'
  2. Run the System Access step
  3. Confirm that the step retries while the setfacl command is being run, until it succeeds.

Relevant logs showing retry

des_workers        | [DJANGO] $(processName)s INFO 2024-11-13 20:19:16,515 receivers designsafe.apps.api.notifications.receivers.send_setup_event:53: Sending setup event through websocket
des_workers        | [DJANGO] WARNING 2024-11-13 20:19:17,574 decorators designsafe.libs.common.decorators.f_retry:127: <class 'tapipy.errors.UnauthorizedError'>, Retrying in 3 seconds...
des_workers        | [DJANGO] $(processName)s WARNING 2024-11-13 20:19:17,574 decorators designsafe.libs.common.decorators.f_retry:127: <class 'tapipy.errors.UnauthorizedError'>, Retrying in 3 seconds...
des_workers        | [DJANGO] WARNING 2024-11-13 20:19:21,846 decorators designsafe.libs.common.decorators.f_retry:127: <class 'tapipy.errors.UnauthorizedError'>, Retrying in 6 seconds...
des_workers        | [DJANGO] $(processName)s WARNING 2024-11-13 20:19:21,846 decorators designsafe.libs.common.decorators.f_retry:127: <class 'tapipy.errors.UnauthorizedError'>, Retrying in 6 seconds...
des_workers        | [DJANGO] INFO 2024-11-13 20:19:30,155 system_access_v3 designsafe.apps.onboarding.steps.system_access_v3.process:165: Ensuring directory exists for user=sal_test then going to run setfacl on system=designsafe.storage.default path=sal_test

@rstijerina rstijerina merged commit 1eecb60 into main Nov 13, 2024
5 checks passed
@rstijerina rstijerina deleted the task/WI-221--onboarding-retry branch November 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants