uds: cleanup error reporting to user #136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
commented
Aug 5, 2024
src/cli/cmd/login/mod.rs
Outdated
Comment on lines
215
to
224
| if !nix::unistd::Uid::effective().is_root() { | ||
| return Err(eyre!("`fh login` is attempting to update a file owned by root, please re-run the same command, prefixed with `sudo -i`.")) | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm still missing something, this outputs the backtrace message too, even though it's just un-Try'd in this function's caller.
colemickens
force-pushed
the
colemickens/uds-error-cleanup
branch
from
bc1cb93 to
6d64a9b
Compare
colemickens
force-pushed
the
colemickens/uds-error-cleanup
branch
from
6d64a9b to
1780425
Compare
colemickens
force-pushed
the
colemickens/uds-error-cleanup
branch
from
5d0b364 to
44e602c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.