Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do less without dnixd #145

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Do less without dnixd #145

merged 6 commits into from
Sep 26, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 26, 2024

Closes #144

Commit one moves all the "no-dnixd" code into the branch where we don't use it.

Commit two stops writing to the dnixd state directory when dnixd isn't available.

@grahamc grahamc requested a review from colemickens September 26, 2024 18:53
@grahamc
Copy link
Member Author

grahamc commented Sep 26, 2024

Updates:

  1. Supports reading a token from a file, so I can test this on a machine I don't have copy-paste access to.
  2. Adds a ton of wrap_err calls so IO's get contextualized
  3. Handles missing nix.conf's when reading existing config files, defaulting to a "".

With these changes, fh login works as expected on a fresh install of vanilla Nix.

@grahamc grahamc merged commit e1b68fc into main Sep 26, 2024
8 checks passed
@grahamc grahamc deleted the do-less-without-dnixd branch September 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<autogenerated-issue> failed to connect to determinate-nixd socket, will not attempt to use it.
2 participants