-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional inputs #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
grahamc
commented
Oct 7, 2023
cole-h
reviewed
Oct 10, 2023
cole-h
reviewed
Oct 10, 2023
Base automatically changed from
cole/ds-1270-fh-convert-replace-github-urls-with-flakehubcom-urls-when
to
main
October 10, 2023 14:57
…s.bar.follows = "nixpkgs"; to be an input using the url nixpkgs.
grahamc
force-pushed
the
additional-inputs
branch
from
October 10, 2023 18:52
4ee3ac5
to
05d003b
Compare
cole-h
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate that flake.nix
supports indented strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends convert to support more cases.
URI-types become strings:
and IndentedStrings, such as they are, are converted too:
and nixpkgs/release-mm.yy are supported -- migrated to releases now.
Also, while running fh across every determinatesystems project, I found another issue. When a flake.nix looks like this:
rust-overlay
's input URL appears to be replaced with "nixpkgs", causing the result to be:I fixed this as well by not considering
inputs.rust-overlay.inputs.nixpkgs.follows = "nixpkgs";
to be an input line.