Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login: only set netrc-file once in Nix config #91

Merged
merged 3 commits into from
Dec 11, 2023
Merged

login: only set netrc-file once in Nix config #91

merged 3 commits into from
Dec 11, 2023

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Dec 11, 2023

No description provided.

@cole-h cole-h requested a review from lucperkins December 11, 2023 18:20
lucperkins
lucperkins requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@lucperkins lucperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit

src/cli/cmd/login/mod.rs Show resolved Hide resolved
@cole-h cole-h changed the title login: conceal pasted token login: only set netrc-file once in Nix config Dec 11, 2023
@cole-h cole-h merged commit 7f88b85 into main Dec 11, 2023
7 checks passed
@cole-h cole-h deleted the cole/fh-94-only-add-netrc-file-directive-once branch December 11, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-h @lucperkins