Feat/14 user entity #30

dongyoungs · 2023-09-15T11:31:54Z

📝 PR Summary

유저 관련 엔터티 추가

🌲 Working Branch

feat/ user

🌲 TODOs

개발용 유저 생성 API 추가

Related Issues

fix : 구글 스타일 형식에 맞게 수정

donsonioc2010 · 2023-09-16T06:39:22Z

@devmelonlee @dongyoungs Conflicts문제 해결해주세요~

bongsh0112 · 2023-09-16T06:39:41Z

Api/src/main/java/playlist/server/config/security/SecurityUtils.java

+        // 스웨거 유저일시 유저 아이디 0 반환
+        return 0L;
+    }
+}


굿굿 좋습니다

bongsh0112 · 2023-09-16T06:40:35Z

Api/src/main/java/playlist/server/user/controller/UserController.java

+    @GetMapping("/create")
+    public void createDevUser(@RequestParam String email, @RequestParam String password) {
+        log.info("email, password : " + email + "  " + password);
+
+        UserCreateDTO userCreateDTO = new UserCreateDTO(email, password);
+        devLoginService.execute(userCreateDTO);
+
+        // model.addAttribute("email", email);
+        // model.addAttribute("password",password);
+
+    }
+}


RequestParam으로 값이 두개나 들어가는 것은 좋지 않습니다
password는 더더욱 uri에 표시되면 좋지 않겠죠
email, password를 하나의 DTO로 받는다면 좋겠죠?
dto 패키지에 UserCreateRequest와 같은 이름의 DTO를 만들어 받아보세요!
tify 프로젝트의 PostFavorAnswerRequest 클래스를 참고해보세요

네 참고하겠습니다

확인했습니다 추후 API 플리퀘스트시 반영해서 올리겠습니다

bongsh0112 · 2023-09-16T06:44:16Z

Api/src/main/java/playlist/server/user/model/dto/UserCreateDTO.java

+public class UserCreateDTO {
+    private final String email;
+    private final String password;
+
+    // @QueryProjection
+    public UserCreateDTO(String email, String password) {
+        this.email = email;
+        this.password = password;
+    }
+}


좋습니다
위에서 말한 UserCreateRequest와의 통합을 고려해보세요

bongsh0112 · 2023-09-16T06:44:42Z

Api/src/main/java/playlist/server/user/service/devLoginService.java

+    public void execute(UserCreateDTO userCreateDTO) {
+        User user =
+                User.builder()
+                        .email(userCreateDTO.getEmail())
+                        .password(userCreateDTO.getPassword())
+                        .role(AccountRole.ADMIN)
+                        .build();
+        userAdaptor.save(user);
+    }


@builder 패턴으로 구현한 것 좋습니다

bongsh0112 · 2023-09-16T06:45:29Z

Api/src/main/java/playlist/server/utils/UserUtils.java

+public class UserUtils {
+
+    private final UserAdaptor userAdaptor;
+
+    public Long getUserId() {
+        return SecurityUtils.getCurrentUserId();
+    }
+
+    public User getUser() {
+        return userAdaptor.query(SecurityUtils.getCurrentUserId());
+    }
+}


Utils class로 자주 써야하는 메소드를 따로 구현해놓은 것 좋네요

bongsh0112 · 2023-09-16T06:47:51Z

Domain/src/main/java/playlist/server/domain/domains/AbstractTimeStamp.java

+@Getter
+@MappedSuperclass
+@EntityListeners(value = {AuditingEntityListener.class})
+public abstract class AbstractTimeStamp {
+
+    @Column(
+            name = "created_at",
+            nullable = false,
+            columnDefinition = "TIMESTAMP DEFAULT CURRENT_TIMESTAMP")
+    @CreationTimestamp
+    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd hh:mm:ss")
+    private Timestamp createdAt;
+
+    @Column(
+            name = "updated_at",
+            nullable = false,
+            columnDefinition = "TIMESTAMP DEFAULT CURRENT_TIMESTAMP")
+    @UpdateTimestamp
+    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd hh:mm:ss")
+    private Timestamp updatedAt;
+}


AbstractTimeStamp 추상클래스를 이용해서
어떤 기능을 구현한 걸까요?

bongsh0112 · 2023-09-16T06:51:31Z

Domain/src/main/java/playlist/server/domain/domains/auth/domain/User.java

+
+@Getter
+@Entity
+@Table(name = "user")


모든 Table 이름의 경우 mysql option과 겹칠 위험을 줄이고
통일성을 위해
tbl_user와 같이 수정해주세요

네 수정하겠습니다.

bongsh0112 · 2023-09-16T06:52:18Z

Domain/src/main/java/playlist/server/domain/domains/auth/domain/User.java

+    @Enumerated(EnumType.ORDINAL)
+    @Column(nullable = false, name = "role", columnDefinition = "varchar(32) default 'USER'")


Enum 타입이 mysql에서 varchar로 변하지 않는 것을 이런식으로 오류를 잡는 것 좋습니다.

bongsh0112 · 2023-09-16T06:52:42Z

Domain/src/main/java/playlist/server/domain/domains/notificate/domain/Setting.java

+    boolean etc_param1;
+
+    boolean etc_param2;
+
+    boolean etc_param3;
+
+    boolean etc_param4;
+
+    boolean etc_param5;
+
+    boolean etc_param6;
+
+    boolean etc_param7;
+
+    boolean etc_param8;
+
+    boolean etc_param9;


음 이부분은 주석처리를 먼저 해놓는게....
어떨지?

bongsh0112 · 2023-09-16T06:53:21Z

Domain/src/main/java/playlist/server/domain/domains/notificate/domain/Setting.java

+    @Column(
+            name = "updated_at",
+            nullable = false,
+            columnDefinition = "TIMESTAMP DEFAULT CURRENT_TIMESTAMP")
+    @UpdateTimestamp
+    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd hh:mm:ss")
+    private Timestamp createdAt;


이 코드가 위 리뷰들 중 어떤 하나의 답이 될 수 있겠네요

ㅎㅎㅎ넵!

아 급하게하느라 기껏 추상클래스 만든거 간과했네요 수정하겠습니다

bongsh0112 · 2023-09-16T06:54:11Z

Domain/src/main/java/playlist/server/domain/domains/auth/domain/User.java

+    private LoginType loginType;
+
+    @NotNull
+    @Column(name = "fail_cnt", nullable = false)


컬럼의 이름같은 경우 카멜케이스를 자동으로 바꿔주기 때문에 이렇게 다 쓸 필요는 없답니다

확인했습니다

devmelonlee

확인했습니다

bongsh0112 and others added 7 commits September 14, 2023 23:14

feat: User Entity 작성 & User Repository 작성 & UserUtils 작성 #14

37220b5

edit: spotlessApply #14

149edbe

feat: User Test api 구현 (TODO : User 생성관련 이슈 해결해야함 #14

bc29368

feat: User Test api 구현 (TODO : User 생성관련 이슈 해결해야함) #14

5a9e0e7

feat : 유저 엔터티 생성 빌더패턴으로 구현

ca8bb3e

feat: Auth 관련 테이블 객체(엔터티) 생성

fdd3f41

fix : 구글 스타일 형식에 맞게 수정

feat : Notificate 관련 엔터티 구현

3703b14

bongsh0112 reviewed Sep 16, 2023

View reviewed changes

devmelonlee reviewed Sep 16, 2023

View reviewed changes

feat: User entity 수정

c7d7ebc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/14 user entity #30

Feat/14 user entity #30

dongyoungs commented Sep 15, 2023 •

edited

Loading

donsonioc2010 commented Sep 16, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

devmelonlee Sep 16, 2023

dongyoungs Sep 18, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

devmelonlee Sep 16, 2023

bongsh0112 Sep 16, 2023

bongsh0112 Sep 16, 2023

devmelonlee Sep 16, 2023

bongsh0112 Sep 16, 2023

devmelonlee Sep 16, 2023

dongyoungs Sep 18, 2023

bongsh0112 Sep 16, 2023

dongyoungs Sep 18, 2023

devmelonlee left a comment

		@Enumerated(EnumType.ORDINAL)
		@Column(nullable = false, name = "role", columnDefinition = "varchar(32) default 'USER'")

Feat/14 user entity #30

Are you sure you want to change the base?

Feat/14 user entity #30

Conversation

dongyoungs commented Sep 15, 2023 • edited Loading

📝 PR Summary

🌲 Working Branch

🌲 TODOs

Related Issues

donsonioc2010 commented Sep 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devmelonlee left a comment

Choose a reason for hiding this comment

dongyoungs commented Sep 15, 2023 •

edited

Loading