#31 Visual Studio build is failing with error: "An unhandled error ha…

…s occurred. Collection was modified"
DevTeam · Aug 8, 2023 · 6ac11d9 · 6ac11d9
1 parent f0c54be
commit 6ac11d9
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/src/Pure.DI.Core/Core/DependencyGraphBuilder.cs b/src/Pure.DI.Core/Core/DependencyGraphBuilder.cs
@@ -188,7 +188,7 @@ bool TryCreateOnCannotResolve(MdSetup mdSetup, DependencyNode ownerNode, Injecti
             processed.Add(node);
         }
 
-        foreach (var key in map.Keys.Where(i => ReferenceEquals(i.Tag, MdTag.ContextTag)))
+        foreach (var key in map.Keys.Where(i => ReferenceEquals(i.Tag, MdTag.ContextTag)).ToArray())
         {
             map.Remove(key);
         }

diff --git a/src/Pure.DI.Core/Core/Generator.cs b/src/Pure.DI.Core/Core/Generator.cs
@@ -166,8 +166,6 @@ public Unit Build(IEnumerable<SyntaxUpdate> updates)
                     default,
                     LogId.ErrorUnhandled,
                     error));
-
-            throw;
         }
         finally
         {

diff --git a/src/Pure.DI.Core/Core/LogInfoBuilder.cs b/src/Pure.DI.Core/Core/LogInfoBuilder.cs
@@ -50,7 +50,17 @@ public LogInfo Build(LogEntry logEntry)
         DiagnosticDescriptor? descriptor = default;
         if (!string.IsNullOrWhiteSpace(logEntry.Id))
         {
-            descriptor = new DiagnosticDescriptor(logEntry.Id!, severityCode, firstLine, severityCode, logEntry.Severity, true);
+            var message = new StringBuilder(firstLine);
+            if (logEntry.Exception is { } exception)
+            {
+                message.Append(", Message: \"");
+                message.Append(exception.Message);
+                message.Append("\", Stack Trace: \"");
+                message.Append(exception.StackTrace.Replace(System.Environment.NewLine, " "));
+                message.Append('"');
+            }
+
+            descriptor = new DiagnosticDescriptor(logEntry.Id!, severityCode, message.ToString(), severityCode, logEntry.Severity, true);
         }
 
         return new LogInfo(

diff --git a/src/Pure.DI/Pure.DI.csproj b/src/Pure.DI/Pure.DI.csproj
@@ -20,7 +20,7 @@
     </PropertyGroup>
 
     <!--<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
-      <DefineConstants>TRACE;TRACE_MODE</DefineConstants>
+      <DefineConstants>DEBUG_MODE</DefineConstants>
     </PropertyGroup>-->
 
     <ItemGroup>