Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP (DAVIS to DVS) #71

Closed
wants to merge 1 commit into from
Closed

WIP (DAVIS to DVS) #71

wants to merge 1 commit into from

Conversation

valvals
Copy link
Collaborator

@valvals valvals commented May 3, 2024

It works.
But it is difficult to split plotly_maker.h (.cpp) and array_core.h. (Linking problems. You can try it.) So, for now they use the same dvs namespace.
Working on it.

@valvals valvals requested review from AntonMrt and ValeryStk May 3, 2024 20:53
@AntonMrt
Copy link
Collaborator

AntonMrt commented May 3, 2024

Look at davis-to-dvs-anton branch.
I have separated public functions "show" to new public namespace "dv". While other functions located at "dvs"
Now all is working, one hdr also works.

@ValeryStk
Copy link
Collaborator

ValeryStk commented May 4, 2024

How to split it without extra namespaces? Just namespace and public dvs namespace.

@ValeryStk
Copy link
Collaborator

ValeryStk commented May 4, 2024

Lets discuss it later...

@AntonMrt
Copy link
Collaborator

AntonMrt commented May 4, 2024

The name can be referred to from the scopes in the other translation units. Variables and functions with external linkage also have language linkage, which makes it possible to link translation units written in different programming languages.

Any of the following names declared at namespace scope have external linkage, unless they are declared in an unnamed namespace or their declarations are attached to a named module and are not exported(since C++20):
https://en.cppreference.com/w/cpp/language/namespace#Unnamed_namespaces
https://en.cppreference.com/w/cpp/language/storage_duration

@AntonMrt
Copy link
Collaborator

AntonMrt commented May 4, 2024

@valvals
Copy link
Collaborator Author

valvals commented May 5, 2024

Ok. Let's merge your solution to main branch.

@valvals valvals closed this May 8, 2024
@AntonMrt AntonMrt deleted the DVS branch May 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants