Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings 'common' to parent + fix lack of surface settings in html #95

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Settings 'common' to parent + fix lack of surface settings in html #95

merged 2 commits into from
Jun 4, 2024

Conversation

AntonMrt
Copy link
Collaborator

  1. Settings struct was changed
  2. x,y,z label were added to genereting html page

Please approve this PR onle after aprooving PR-mega-templates

@AntonMrt AntonMrt requested a review from ValeryStk May 28, 2024 08:51
valvals
valvals requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@valvals valvals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved mega templates PR.
Resolve conflicts, please.

@AntonMrt AntonMrt force-pushed the settings-common-to-parent branch from 875d281 to 62ae2fb Compare June 4, 2024 10:45
@AntonMrt
all work
9f626cf 
wip

wip

change tests

adding 2d megatemplate

WIP

delete vector implementation

del include

change settings struct

FINISH!

fix lack of surface settings in html

formatting

fixes for Davis-one-hdr

small fix
@AntonMrt AntonMrt force-pushed the settings-common-to-parent branch from 62ae2fb to 9f626cf Compare June 4, 2024 10:48
@AntonMrt AntonMrt requested a review from valvals June 4, 2024 10:58
valvals
valvals approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@valvals valvals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🐱‍👤

@valvals valvals merged commit 39f212e into main Jun 4, 2024
4 checks passed
@valvals valvals deleted the settings-common-to-parent branch June 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valvals valvals valvals approved these changes

@ValeryStk ValeryStk Awaiting requested review from ValeryStk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonMrt @valvals