-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings when using typst 0.12.0 #71
Conversation
Wow, you're fast! @bluen Thanks for updating the CI |
Hmm it seems that |
@bluen Do you mind if I push some further changes to this PR? |
Strange...
(Edit: |
Not at all 👍 |
Oh interesting! That may explain things. I used the non-tagged version. I'll switch over and try again. Thanks! |
@bluen Ok I pushed some changes, but the tests are still failing. Could you give them a try on your machine? They pass locally for me, but I wonder if this is a font issue (I tested on Windows). Thanks! |
Here's what I get as diffs (from failing tests) after
These diffs seem to look exactly like the ones from the last failing CI test. Note: I'm on a mac, so using the script to install the font won't work (it installs them in |
Awesome, thank you for doing that. I'm good with merging this now. And thanks again for the PR! |
Closes #70