Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings when using typst 0.12.0 #71

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Fix warnings when using typst 0.12.0 #71

merged 10 commits into from
Oct 22, 2024

Conversation

bluen
Copy link
Contributor

@bluen bluen commented Oct 21, 2024

Closes #70

@DeveloperPaul123
Copy link
Owner

Wow, you're fast! @bluen Thanks for updating the CI

@DeveloperPaul123
Copy link
Owner

Hmm it seems that typst-test does not support typst 0.12.0 yet. If I make the same changes to the test.typ as you did in the main template code, the compilation step fails.

@DeveloperPaul123
Copy link
Owner

@bluen Do you mind if I push some further changes to this PR?

@bluen
Copy link
Contributor Author

bluen commented Oct 21, 2024

Hmm it seems that typst-test does not support typst 0.12.0 yet. If I make the same changes to the test.typ as you did in the main template code, the compilation step fails.

Strange...
The tagged version of typst-test compiles it (cargo install --locked --git https://github.com/tingerrr/typst-test --tag ci-semi-stable --force), but the one built from the main branch (cargo install --locked --git https://github.com/tingerrr/typst-test --force indeed fails with

failed resume
          Compilation of test failed
          error: unexpected argument: spacing
             ┌─ /Users/jurgenkleer/Documents/modern-cv/tests/resume/test.typ:20:9
             │
          20 │ #set par(spacing: 0.75em, justify: true)
             │          ^^^^^^^^^^^^^^^

(Edit: typst-test installed unlocked - cargo install --git https://github.com/tingerrr/typst-test --force fails compiling it in the same way)

@bluen
Copy link
Contributor Author

bluen commented Oct 21, 2024

@bluen Do you mind if I push some further changes to this PR?

Not at all 👍

@DeveloperPaul123
Copy link
Owner

Hmm it seems that typst-test does not support typst 0.12.0 yet. If I make the same changes to the test.typ as you did in the main template code, the compilation step fails.

Strange... The tagged version of typst-test compiles it (cargo install --locked --git https://github.com/tingerrr/typst-test --tag ci-semi-stable --force), but the one built from the main branch (cargo install --locked --git https://github.com/tingerrr/typst-test --force indeed fails with

failed resume
          Compilation of test failed
          error: unexpected argument: spacing
             ┌─ /Users/jurgenkleer/Documents/modern-cv/tests/resume/test.typ:20:9
             │
          20 │ #set par(spacing: 0.75em, justify: true)
             │          ^^^^^^^^^^^^^^^

Oh interesting! That may explain things. I used the non-tagged version. I'll switch over and try again. Thanks!

@DeveloperPaul123
Copy link
Owner

@bluen Ok I pushed some changes, but the tests are still failing. Could you give them a try on your machine? They pass locally for me, but I wonder if this is a font issue (I tested on Windows).

Thanks!

@bluen
Copy link
Contributor Author

bluen commented Oct 22, 2024

Here's what I get as diffs (from failing tests) after

  • uninstalling font 'Source Sans Pro'
  • installing font 'Source Sans 3' (OTF-source-sans-3.052R.zip, same version the script uses)
  • updating the branch
  • reinstalling typst-test ci-semi-stable

image
image

These diffs seem to look exactly like the ones from the last failing CI test.

Note: I'm on a mac, so using the script to install the font won't work (it installs them in ~/.fonts/, but macos needs them in ~/Library/Fonts.

@DeveloperPaul123
Copy link
Owner

Awesome, thank you for doing that. I'm good with merging this now. And thanks again for the PR!

@DeveloperPaul123 DeveloperPaul123 merged commit 4c417a7 into DeveloperPaul123:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typst 0.12 - just minor changes necessary?
2 participants