Fix bad alignment of the contacts #82
Merged
+44
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, I'll be able to test it out soon. Do you have examples where the alignment was previously broken? Would be good to add this to the tests. |
|
Just removing the website should lead to that issue (and if you include the website, there is a strange whitespace in front of the website/the separators are not spaced equally). |
|
I see, thanks for that. Is this issue present in the resume as well? Or just the coverletter? |
|
Never mind, those are centered. This looks good to me! I'll add this to the test cases though so changes can be caught. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that sometimes the contacts didn't fully align to the right.
I simplified the separation process by pushing each used contact field to the contacts list and then merging them together with the
.join(separator)Typst function.This should make it more flexible for the different variations of selected contacts fields.