Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add validation job #591

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Oct 24, 2024

For now, this job only validates the JSON language files in lang/, but in the future, more validation/test steps can be added.

This helps catch formatting mistakes such as 1228ab0 (later fixed by 9ee872f).

Example run: https://github.com/guihkx/TwitchDropsMiner/actions/runs/11506407609/job/32030275387

For now, this job only validates the JSON language files in "lang/",
but in the future, more validation/test steps can be added.
@DevilXD DevilXD added the Enhancement New feature or request label Oct 25, 2024
@DevilXD
Copy link
Owner

DevilXD commented Oct 25, 2024

Interesting. I can't help but notice that CI can really be setup to do a lot of things.

I should really take a closer look at how to do all of this, on a level that I can write something myself.

Thank you for your contribution once again 🙂

@DevilXD DevilXD merged commit 9b44968 into DevilXD:master Oct 25, 2024
5 checks passed
@guihkx guihkx deleted the ci-add-validation-job branch October 25, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants