Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Minor Updates #11

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 404.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying 404 pages (not found).
* The template for displaying 404 pages (not found)
*
* @link https://codex.wordpress.org/Creating_an_Error_404_Page
*
Expand Down
2 changes: 1 addition & 1 deletion archive.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying archive pages.
* The template for displaying archive pages
*
* @link https://codex.wordpress.org/Template_Hierarchy
*
Expand Down
4 changes: 2 additions & 2 deletions comments.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying comments.
* The template for displaying comments
*
* This is the template that displays the area of the page that contains both the current comments
* and the comment form.
Expand Down Expand Up @@ -33,7 +33,7 @@
'<span>' . get_the_title() . '</span>'
);
?>
</h2>
</h2><!-- .comments-title -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using emmet for writing the HTML markup. These and comments are added automatically through it's filters. In this case exactly we are not adding end comments - that being the line HTML elements. You can see more about this in here - http://docs.emmet.io/filters/ and in here https://github.com/sergeche/emmet-sublime/issues/225

It's okay to leave it as it is for now, but do not add more like this one in the future as the whole theme is full of such elements and if we add just for one it will less systematic.


<?php if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) ) : // Are there comments to navigate through? ?>
<nav id="comment-nav-above" class="navigation comment-navigation" role="navigation">
Expand Down
2 changes: 1 addition & 1 deletion footer.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying the footer.
* The template for displaying the footer
*
* Contains the closing of the #content div and all content after.
*
Expand Down
12 changes: 6 additions & 6 deletions functions.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* DevriX Starter functions and definitions.
* DevriX Starter functions and definitions
*
* @link https://developer.wordpress.org/themes/basics/theme-functions/
*
Expand Down Expand Up @@ -34,7 +34,7 @@
require get_template_directory() . '/inc/jetpack.php';

/**
* Better support for responsive images out of the box
* Better support for responsive images out of the box.
*/
require get_template_directory() . '/inc/images.php';

Expand Down Expand Up @@ -75,7 +75,7 @@ function dxstarter_setup() {
add_theme_support( 'post-thumbnails' );

/**
* Sample post thumbnail sizes. Change these to fit your theme
* Sample post thumbnail sizes. Change these to fit your theme.
*
* @since DX Starter 1.1.0
*/
Expand Down Expand Up @@ -164,10 +164,10 @@ function dxstarter_scripts() {
}
}

// Enqueue the only styling file here that is build with Gulp
// Enqueue the only styling file here that is build with Gulp.
wp_enqueue_style( 'stylesheet', get_template_directory_uri() . '/assets/css/master' . $suffix . '.css' );

// And the only JS file that is build with Gulp
// And the only JS file that is build with Gulp.
wp_enqueue_script( 'scripts', get_template_directory_uri() . '/assets/scripts/bundle' . $suffix . '.js', array( "jquery" ), '20170204', true );


Expand All @@ -178,7 +178,7 @@ function dxstarter_scripts() {
add_action( 'wp_enqueue_scripts', 'dxstarter_scripts' );

/**
* Remove the margin-top styling added to the HTML tag by default from WordPress
* Remove the margin-top styling added to the HTML tag by default from WordPress.
*/
function dxstarter_remove_html_margin() {
remove_action( 'wp_head', '_admin_bar_bump_cb' );
Expand Down
8 changes: 4 additions & 4 deletions header.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The header for our theme.
* The header for our theme
*
* This is the template that displays all of the <head> section and everything up until <div id="content">
*
Expand Down Expand Up @@ -53,8 +53,8 @@
</div><!-- .menu-primary-container -->
</nav><!-- #site-navigation -->
</div><!-- .site-header-inner -->
</div><!-- /columns -->
</div><!-- /row -->
</header><!-- #site-header -->
</div><!-- .columns -->
</div><!-- .row -->
</header><!-- #masthead -->

<div id="content" class="site-content">
5 changes: 2 additions & 3 deletions inc/custom-header.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Sample implementation of the Custom Header feature.
* Sample implementation of the Custom Header feature
*
* You can add an optional custom header image to header.php like so ...
*
Expand All @@ -14,9 +14,8 @@
*
* @package DX Starter
*/

/**
* Sample implementation of the Custom Header feature.
* Sample implementation of the Custom Header feature
*
* @link https://developer.wordpress.org/themes/functionality/custom-headers/
*
Expand Down
2 changes: 1 addition & 1 deletion inc/customizer.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* DevriX Starter Theme Customizer.
* DevriX Starter Theme Customizer
*
* @package DevriX_Starter
*/
Expand Down
2 changes: 1 addition & 1 deletion inc/extras.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Custom functions that act independently of the theme templates.
* Custom functions that act independently of the theme templates
*
* Eventually, some of the functionality here could be replaced by core features.
*
Expand Down
1 change: 0 additions & 1 deletion inc/images.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?php

/**
* Add custom image sizes attribute to enhance responsive image functionality
* for post thumbnails
Expand Down
2 changes: 1 addition & 1 deletion inc/jetpack.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Jetpack Compatibility File.
* Jetpack Compatibility File
*
* @link https://jetpack.me/
*
Expand Down
2 changes: 1 addition & 1 deletion inc/template-tags.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Custom template tags for this theme.
* Custom template tags for this theme
*
* Eventually, some of the functionality here could be replaced by core features.
*
Expand Down
2 changes: 1 addition & 1 deletion index.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The main template file.
* The main template file
*
* This is the most generic template file in a WordPress theme
* and one of the two required files for a theme (the other being style.css).
Expand Down
2 changes: 1 addition & 1 deletion page.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying all pages.
* The template for displaying all pages
*
* This is the template that displays all pages by default.
* Please note that this is the WordPress construct of pages
Expand Down
6 changes: 3 additions & 3 deletions readme.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
=== DevriX Starter ===

Contributors: automattic
Contributor: DevriX
Tags: translation-ready, custom-background, theme-options, custom-menu, post-formats, threaded-comments

Requires at least: 4.0
Tested up to: 4.4.2
Tested up to: 4.7.2
Stable tag: 1.0.0
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Expand All @@ -13,7 +13,7 @@ A starter theme called DevriX Starter, or underscores.

== Description ==

Hi. I'm a starter theme called DevriX Starter, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
Hi. I'm a starter theme called DevriX Starter. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.

== Installation ==

Expand Down
2 changes: 1 addition & 1 deletion search.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying search results pages.
* The template for displaying search results pages
*
* @link https://developer.wordpress.org/themes/basics/template-hierarchy/#search-result
*
Expand Down
2 changes: 1 addition & 1 deletion sidebar.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The sidebar containing the main widget area.
* The sidebar containing the main widget area
*
* @link https://developer.wordpress.org/themes/basics/template-files/#template-partials
*
Expand Down
2 changes: 1 addition & 1 deletion single.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* The template for displaying all single posts.
* The template for displaying all single posts
*
* @link https://developer.wordpress.org/themes/basics/template-hierarchy/#single-post
*
Expand Down
8 changes: 4 additions & 4 deletions snippets/section-faq-large.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Our basic FAQ layout.
* Our basic FAQ layout
*
* @since DX Starter v1.3.0
* @uses assets/sass/prebuilds/elements/_section-faq-elements.scss
Expand All @@ -14,9 +14,9 @@
<header class="section-heading">
<h2 class="heading-title">This is the section's heading</h2><!-- .heading-title -->
<p class="heading-subtext">Under which you can even add parahraph with more text</p><!-- .heading-subtext -->
</header><!-- .flex-grid-wrapper -->
</div>
</div><!-- /end row -->
</header><!-- .section-heading -->
</div><!-- .columns -->
</div><!-- .row -->

<div class="row">
<!-- Note: For the faq elements there is .number element.
Expand Down
2 changes: 1 addition & 1 deletion template-parts/content-none.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Template part for displaying a message that posts cannot be found.
* Template part for displaying a message that posts cannot be found
*
* @link https://codex.wordpress.org/Template_Hierarchy
*
Expand Down
2 changes: 1 addition & 1 deletion template-parts/content-page.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Template part for displaying page content in page.php.
* Template part for displaying page content in page.php
*
* @link https://codex.wordpress.org/Template_Hierarchy
*
Expand Down
2 changes: 1 addition & 1 deletion template-parts/content-search.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Template part for displaying results in search pages.
* Template part for displaying results in search pages
*
* @link https://codex.wordpress.org/Template_Hierarchy
*
Expand Down
2 changes: 1 addition & 1 deletion template-parts/content.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Template part for displaying posts.
* Template part for displaying posts
*
* @link https://codex.wordpress.org/Template_Hierarchy
*
Expand Down
1 change: 0 additions & 1 deletion templates/styleguide.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?php

/**
* Template Name: >> Theme Styleguide <<
*
Expand Down