Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use remote schemas #123

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Feature/use remote schemas #123

merged 3 commits into from
Aug 2, 2024

Conversation

southeo
Copy link
Contributor

@southeo southeo commented Aug 1, 2024

No description provided.

@southeo southeo requested a review from TomDijkema August 1, 2024 18:28
TomDijkema
TomDijkema previously approved these changes Aug 2, 2024
Copy link

@TomDijkema TomDijkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, overall looks very good! Love the refs to other schemas!

"description": "The motivation for the annotation. Based on a selection of https://www.w3.org/TR/annotation-model/#motivation-and-purpose. The motivation ods:adding is added for DiSSCo's purposes.",
"enum": [
"ods:adding",
"ods:deleting",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be tombstoning no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is automatically pulled from schemas.dissco,tech, it's ods:deleted there

@@ -367,6 +181,7 @@
"ods:version",
"oa:motivation",
"oa:hasTarget",
"oa:hasBody",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@southeo southeo merged commit b79ba23 into main Aug 2, 2024
1 of 2 checks passed
@southeo southeo deleted the feature/use-remote-schemas branch August 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants