-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use human readable type for responses #155
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good clean up, check if this impacts Tom in any way
🧼
import lombok.Getter; | ||
|
||
@Getter | ||
public enum FdoType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this list is final right? This is what we will use when we move to production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those 2 things aren't the same 😆 It's what we'll use for production though
DATA_MAPPING("https://doi.org/21.T11148/ce794a6f4df42eb7e77e", "ods:DataMapping"), | ||
@JsonProperty("https://doi.org/21.T11148/22e71a0015cbcfba8ffa") | ||
@JsonAlias("ods:MachineAnnotationService") | ||
MAS("https://doi.org/21.T11148/22e71a0015cbcfba8ffa", "ods:MachineAnnotationService"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it should be this:
https://dtr-test.pidconsortium.net/#objects/21.T11148/a369e128df5ef31044d4
Quality Gate failedFailed conditions |
we have 2 type fields:
@type
, which is human-readableods:fdoType
, which is a DOIFor the responses, we need to provide a type to adhere to jsonAPI standards.
We had some objects that returned fdo types, some that returned human-readable types. Now, we return the human readable for the type. this is because we have some response types (e.g.
digitalSpecimenVersions
) that don't have an FDO profile.Jira - back end types should be consistent