Code review

DiSSCo · Oct 17, 2023 · 36b04d2 · 36b04d2
1 parent 3f5f56a
commit 36b04d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/eu/dissco/core/translator/service/BioCaseService.java b/src/main/java/eu/dissco/core/translator/service/BioCaseService.java
@@ -179,7 +179,8 @@ private void processUnit(DataSet dataset, Unit unit)
         var attributes = digitalSpecimenDirector.assembleDigitalSpecimenTerm(unitAttributes, false);
         if (attributes.getOdsNormalisedPhysicalSpecimenId() == null
             || attributes.getDwcInstitutionId() == null) {
-          throw new DiSSCoDataException("Cannot find a physical specimen id for specimen record");
+          throw new DiSSCoDataException(
+              "Record does not comply to MIDS level 0 (id and organisation), ignoring record");
         }
         var digitalSpecimen = new DigitalSpecimenWrapper(
             attributes.getOdsNormalisedPhysicalSpecimenId(),

diff --git a/src/main/java/eu/dissco/core/translator/service/DwcaService.java b/src/main/java/eu/dissco/core/translator/service/DwcaService.java
@@ -212,7 +212,8 @@ private Pair<DigitalSpecimenWrapper, List<DigitalMediaObjectEvent>> createDigita
       JsonNode fullRecord) throws DiSSCoDataException {
     var ds = digitalSpecimenDirector.assembleDigitalSpecimenTerm(fullRecord, true);
     if (ds.getOdsNormalisedPhysicalSpecimenId() == null || ds.getDwcInstitutionId() == null) {
-      throw new DiSSCoDataException("Cannot find a physical specimen id for specimen record");
+      throw new DiSSCoDataException(
+          "Record does not comply to MIDS level 0 (id and organisation), ignoring record");
     }
     return Pair.of(new DigitalSpecimenWrapper(
             ds.getOdsNormalisedPhysicalSpecimenId(),