Feature/fdo update #116
Merged
Feature/fdo update #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
southeo
commented
Dec 9, 2024
southeo
commented
- align with fdo 1.0
- introduces "unrecognized" fdo property as a small workaround in the mongodb layer so the handle api won't crash if a pid record has a property from a previous version
samleeflang
reviewed
Dec 10, 2024
| "mediaHost", | ||
| "mediaHostName", | ||
| "linkedDigitalObjectPid", | ||
| "linkedDigitalObjectType", | ||
| "primaryMediaId" | ||
| "primaryMediaId", | ||
| "license", |
There was a problem hiding this comment.
license is a required field but in the Service I don't think we actually set license. Couldn't that create a potential issue?
There was a problem hiding this comment.
Ok this should be removed, also made a pr on opends. If we don't have a license in the FDO record I think we'll somehow survive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.