Bug fix/normalize media #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samleeflang
approved these changes
Jan 8, 2025
| @@ -22,4 +23,8 @@ private ServiceUtils() { | |||
| ); | |||
| } | |||
|
|
|||
| public static String normalizeMediaId(DigitalMediaRequestAttributes request) { | |||
| return request.getLinkedDigitalObjectPid() + ":" + request.getPrimaryMediaId(); | |||
There was a problem hiding this comment.
Ok this is probably good. Although with this particular issue this wouldn't have solved it as it were multiple images with the same URL for the same linkedDigitalObject. But we will fix that at ingestion so that should never occur again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jira for more information