Upsert specimens #73
Merged
Upsert specimens #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samleeflang
reviewed
Dec 12, 2023
| var registeredPhysicalIdentiferMap = registeredPhysicalIdentifiers.stream() | ||
| .collect(Collectors.toMap(row -> new String(row.getData(), StandardCharsets.UTF_8), | ||
| row -> new String(row.getHandle(), StandardCharsets.UTF_8))); | ||
| var writableHandles = pidRepository.checkHandlesWritable( |
There was a problem hiding this comment.
What does the checkHandlesWritable do? Do we have unwritable handles, I don't get this part
There was a problem hiding this comment.
Checks PID state. If the PID is set to "ARCHIVED", then the specimen will get a new PID instead of updating an archived PID.
|
samleeflang
reviewed
Dec 14, 2023
| @@ -97,7 +97,7 @@ public enum FdoProfile { | |||
| private final int index; | |||
|
|
|||
|
|
|||
| private FdoProfile(String attribute, int index) { | |||
| FdoProfile(String attribute, int index) { | |||
There was a problem hiding this comment.
Way are these no longer private?
There was a problem hiding this comment.
"If you do not specify an access modifier the enum constructor it will be implicitly private."
Slowly going to remove the private constructors when I touch enum files
samleeflang
reviewed
Dec 14, 2023
samleeflang
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds upsert endpoint. New specimens are Postgres-Copied. Updated specimens are inserted with Jooq.
We don't verify media objects/annotations haven't been ingested the way we verify specimens. For media/annotation objects, we rely on the respective processing services to verify they haven't been ingested. It might make sense with media objects (since they'll eventually get DOIs), but for annotations, it probably isn't necessary.