Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaObject -> DigitalMedia #88

Merged
merged 2 commits into from
Jun 25, 2024
Merged

MediaObject -> DigitalMedia #88

merged 2 commits into from
Jun 25, 2024

Conversation

southeo
Copy link
Collaborator

@southeo southeo commented Jun 20, 2024 •
edited
Loading

Media Rename

  • renames fdo type MediaObject to DigitalMedia
  • Renames functions
  • No impact on any other service (incl media processor)

Mapping rename

  • mapping -> DataMapping
  • Functions renamed
  • no impact on orchestration service. If the location of the mappings moves from orchestration,dissco.tech/mapping/{id}, then we need to update the api to include the correct location in the pid record

@southeo southeo requested a review from wouteraddink June 20, 2024 04:51
@southeo southeo requested a review from samleeflang June 20, 2024 05:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 20, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

samleeflang
samleeflang approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Could you also update the openDS repo, haven't touched the fdo-type files yet.

@southeo southeo merged commit 48f4d00 into main Jun 25, 2024
1 of 2 checks passed
@southeo southeo deleted the feature/update-digital-media-name branch June 25, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samleeflang samleeflang samleeflang approved these changes

@wouteraddink wouteraddink Awaiting requested review from wouteraddink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@southeo @samleeflang