New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated virtualcollections schema, align with LatimerCore #81

Merged

sharifX merged 9 commits into DiSSCo:master from sharifX:master

Mar 15, 2024

Contributor

sharifX commented Feb 5, 2024

This updated virtual collection JSON schema has specific additions aligned with the LatimerCore (ltc) schema. The schema now incorporates the ltc:ObjectGroup class, encompassing properties: ltc:conditionsOfAccess, ltc:collectionName, ltc:description, and ltc:isKnownToContainTypes. The descriptions included in the schema are taken from the LatimerCore documentation. The comments from #61 has been addressed. The "capabilities" attributes suggest by RDA has been removed. Ltc also has ltc:RecordLevel based on RDA recommendation "The machine-actionable information profile for the collection description digital object." ods:type should be able map to that.


          updated virtualcollections schema, align with LatimerCore

bd9b795

This updated virtual collection JSON schema is with specific additions aligned with the LatimerCore (ltc). The schema now incorporates the ltc:ObjectGroup class, encompassing properties: ltc:conditionsOfAccess, ltc:collectionName, ltc:description, and ltc:isKnownToContainTypes.  The descriptions included in the schema are taken from the LatimerCore documentation. The comments from DiSSCo#61 has been addressed. The "capabilities" attributes suggest by RDA has been removed. Ltc also has ltc:RecordLevel based on RDA recommendation "The machine-actionable information profile for the collection description digital object.". ods:type should be able map to that.

sharifX added the data model label

sharifX requested review from wouteraddink, southeo, samleeflang and TomDijkema

February 5, 2024 20:25

southeo reviewed

View reviewed changes

Contributor

southeo left a comment

Thanks for tackling this. It's good to have latimer core linked to this data model.
In the future, it might be easier to work with a clone the repo on a branch rather than a fork on your own github, so it's easier to keep your version up to-date :)

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

sharifX added 3 commits

February 9, 2024 13:33


          Create README for FDO Profiles

176b021


          Update virtualcollections.json

df68bab

Replaced Handle/DOI mention with PID; make VirtualCollections type const; add desc link to the standards; delete filterName (desc/name is enough).


          Delete data-model/fdo-profiles/0.1.0/README.md

49ddcd6

samleeflang reviewed

View reviewed changes

Contributor

samleeflang left a comment

Almost there, got a couple of additional things too look at.

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Show resolved Hide resolved

sharifX added 2 commits

February 19, 2024 13:16


          Merge branch 'DiSSCo:master' into master

456c527


          address latest PR comments.

66ce136

Fix const value. change isKnownToContainTypes to boolean. leave ltc:conditionsOfAccess as it is for now. add dwc:measurementUnit. make rdf:type required. fix missing quotation. add example object for validation.

sharifX requested review from samleeflang and southeo

February 22, 2024 12:51

samleeflang reviewed

View reviewed changes

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

samleeflang reviewed

View reviewed changes

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

samleeflang reviewed

View reviewed changes

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved


          cleanup, address latest PR comments

Remove examples (will add to the example folder). Add TDWG link and desc. move them next to type for consistency. remove ltc:isKnownToContainTypes as it will be difficult to capture this during ingestion.

sharifX requested a review from samleeflang

February 22, 2024 15:40

samleeflang reviewed

View reviewed changes

Contributor

samleeflang left a comment

Could you take a look at the required fields?
Also the example for the filter doesn't look great.
I think we make it a bit more reusable and less specific by storing it as key-value pairs.

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Show resolved Hide resolved

sharifX requested a review from samleeflang

March 5, 2024 09:35

samleeflang reviewed

View reviewed changes

Contributor

samleeflang left a comment

I think my last comments are still relevant. They were mainly about missing required fields and about the structure of the filter field. Could you check if you pushed all changes?


          Update virtualcollections.json

316e454

changes made: make creator, searchFilters required. Also add required items inside creator and measturementorFacts. Change searchFilter structure with separating key and value.

sharifX requested a review from samleeflang

March 6, 2024 11:21

samleeflang approved these changes

View reviewed changes

Contributor

samleeflang left a comment

Had some minor comments but will approve as well so it can go through

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved

data-model/virtualcollections/v.0.1.0/schemas/virtualcollections.json Outdated Show resolved Hide resolved


          remove ltc:collectionName from required

d1f33f2

Remove ltc:collectionName as it is not required by ltc:ObjectGroup

sharifX merged commit cc0706f into DiSSCo:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels