Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DigitalMedia and DataMapping, added description, bug fixes #98

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

samleeflang
Copy link
Contributor

Renames

Rename of DigitalEntity -> DigitalMedia
Rename of Mapping -> DataMapping

Object changes

Removed unnecessary ods:Mapping nested object in ods:DataMapping
Added descriptions to all properties lacking them (as this looks better on the terms pages)

Bug fixes

Fixed url shared objects

Copy link
Contributor

@TomDijkema TomDijkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity sounded generic and promising, but its good we align with GBIF and use digital media (kinda again) 👍

Copy link
Contributor

@wouteraddink wouteraddink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This naming is more clear. Digital entity is confusing as all digital objects are digital entities. The FDO-types should be aligned with the FDO profiles, so digitalMediaObject used there also needs to be changed at some point

Copy link
Contributor

@southeo southeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@samleeflang samleeflang merged commit 5cf702a into master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants