Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements on api integration #8

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

TomDijkema
Copy link
Collaborator

PR adds small improvements based upon the API integration:

  • Added support for all previously non working filters: query and language
  • Makes sure filters are able to be reset correctly when the user navigates using the forward and back arrows and when the state changes
  • Removed 'prototype' from the header
  • Added links to the CETAF privacy policy to the footer
  • Improved error handling when a request results in a 200, but has no found records. This will now display a different message and disable the 'load more' button

Adds small improvements based on the API.

Makes sure all of the filters can be reset and revert to their original values and inherit the search params. Error handling for empty responses with a 200 for search and the taxonomic page have been improved to know show custom messages and adapted behavior.
Adds implementation for query search to search on the name of taxonomic services. Also adds a link to the privacy policy text in the footer to the CETAF website.
@TomDijkema TomDijkema self-assigned this Jun 14, 2024
@TomDijkema TomDijkema changed the title Small improvements on api Small improvements on api integration Jun 14, 2024
Copy link

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments

src/redux-store/TaxonomicServiceSlice.ts Outdated Show resolved Hide resolved
src/components/general/footer/Footer.tsx Outdated Show resolved Hide resolved
Copy link

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☂️

Commit for resolving Sonar Cloud issues and addressing Review comments
Second commit for resolving Sonar Cloud issues
Copy link

sonarcloud bot commented Jun 14, 2024

@TomDijkema TomDijkema merged commit ca57584 into main Jun 14, 2024
2 checks passed
@TomDijkema TomDijkema deleted the SmallImprovementsOnAPI branch June 14, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants