Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1642: Fix search when clicking x on search bars #909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1642

Summary:

In Chrome or Edge, when you fill in a search bar, a small x appears to clear the search bar. Synchweb should clear the search parameter when you click the x.

Changes:

To test:

  • In Chrome or Edge, go to the proposals page, search for a proposal number. Click the little x in the search bar, check all proposals are shown again

@RichB-DLS
Copy link
Collaborator

Should the clearing of the input re-trigger the search as if with no params supplied? As per when manually clearing it?

Repro steps:
current:

  1. In chrome visit the Proposals page
  2. type 1234 (or something similar with minimal results) into the search field
  3. Note the results list
  4. use the chrome X button to clear the field.
  5. Results are not re-populated.

comparison:

  1. As above steps 1-3
  2. Select all text in the search input and delete
  3. Results are re-populated.

Tested in Fedora Linux
Chrome Version 133.0.6943.141 (Official Build) (64-bit)

@RichB-DLS RichB-DLS self-requested a review February 28, 2025 10:36
@ndg63276
Copy link
Collaborator Author

Should the clearing of the input re-trigger the search as if with no params supplied? As per when manually clearing it?

I would say so, yes. If you clear the search, it should act as if you haven't searched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants